feat: adds `docs` command with optional search flag by lukegalbraithrussell · Pull Request #352 · slackapi/slack-cli

lukegalbraithrussell · 2026-02-24T21:54:44Z

Changelog

The slack docs command opens the slack docs site; its --search flag opens the slack docs search page with the provided search query.

Summary

This PR adds a docs command.

Command	Result
`slack docs`	opens `docs.slack.dev`
`slack docs --search`	opens `docs.slack.dev/search`
`slack docs --search something cool`	`docs.slack.dev/search/?q=something+cool`
`slack docs something`	oopsie you did mess up there try again maybe with the `--search` flag?

This doesn't take advantage of the charm experiment. Next steps though!!!

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

codecov · 2026-02-24T23:20:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.08%. Comparing base (33287a3) to head (030644f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   64.95%   65.08%   +0.13%     
==========================================
  Files         214      215       +1     
  Lines       18118    18179      +61     
==========================================
+ Hits        11768    11832      +64     
+ Misses       5254     5253       -1     
+ Partials     1096     1094       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cmd/docs/docs_test.go

zimeg

☕️ Leaving a few notes from the coffee shop-

zimeg · 2026-02-26T16:14:45Z

cmd/docs/docs.go

+
+	clients.Browser().OpenURL(docsURL)
+
+	// Add trace for analytics


🧪 note: We use these traces for testing certain paths are reached in our E2E tests:

$ SLACK_TEST_TRACE=1 slack docs

It might be nice to update or remove this comment to avoid ongoing confusion toward this!

cmd/docs/docs.go

cmd/docs/docs_test.go

…into docs-command

lukegalbraithrussell · 2026-02-26T16:53:17Z

@zimeg thank you kindly for the coffee shop review. i've updated per your suggestion (while drinking coffee but at home alas)

zimeg

@lukegalbraithrussell I appreciate the fast changes! Coffee finds me good too in the office ☕ ✨

I'm leaving a few more comments about the standalone search patterns. This is a smooth path to a familiar search experience that I'd like to support, but feel free to hold off on those changes if it's not envisioned 👁️‍🗨️

zimeg · 2026-02-26T16:57:29Z

cmd/docs/docs_test.go

+		"handles empty search query as homepage": {
+			CmdArgs: []string{"--search", ""},
+			ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
+				expectedURL := "https://docs.slack.dev"
+				cm.Browser.AssertCalled(t, "OpenURL", expectedURL)
+				cm.IO.AssertCalled(t, "PrintTrace", mock.Anything, slacktrace.DocsSuccess, mock.Anything)
+			},
+			ExpectedOutputs: []string{
+				"Docs Open",
+				"https://docs.slack.dev",
+			},
+		},


🧪 issue: This case is a bit misleading to me! I tried using the search flag without an argument to find this error:

$ slack docs --search Check /Users/eden.zimbelman/.slack/logs/slack-debug-20260226.log for error logs flag needs an argument: --search

should this instead open docs.slack.dev/search?

I do think this would be ideal - perhaps "https://docs.slack.dev/search/" complete - if possible, without an argument?

cmd/root.go

zimeg · 2026-02-26T17:09:29Z

cmd/docs/docs.go

+		},
+	}
+
+	cmd.Flags().StringVar(&searchFlag, "search", "", "search query for Slack docs")


🪬 suggestion: Related to the "required" search value if the "--search" flag is provided - I wonder if we can change this to be a "boolean" value?

This might allow this command to accept 1 argument instead of 0 for sake of being the search query? We might then search if that flag is provided or if an argument is used:

$ slack docs --search $ slack docs "Block Kit" $ slack docs --search "Block Kit"

We ought not need to document the second case IMHO since it's identical to the third, and I don't think such approach limits future changes. Not a blocker here but the examples might need updating before merge!

zimeg

💡 @lukegalbraithrussell This is getting so good! I'm leaving one more comment of edge cases found, but I'm so optimistic!

zimeg · 2026-02-26T22:40:09Z

cmd/docs/docs.go

+	var sectionText string
+
+	// Validate: if there are arguments, --search flag must be used
+	if len(args) > 0 && !cmd.Flags().Changed("search") {


🪬 suggestion: We might still want to keep a max arguments setting for this command, but set to 1. It can be confusing otherwise to find:

(.venv) $ lack docs --search one two 📚 Docs Search https://docs.slack.dev/search/?q=one

Although we can also update this section with "variadic" arguments to join the arguments together - IMHO this might be ideal if not so complicated 👻

it now joins the arguments together!

slack docs --search one two three now returns the search query of "one two three"

zimeg

@lukegalbraithrussell This is so awesome alongside the fast load times 🤩 ✨

Thanks so much for all of the iteration toward this. It's in a solid place to ship I'm finding - LGTM 🚢 💨

zimeg · 2026-02-27T01:49:07Z

cmd/docs/docs.go

+		},
+	}
+
+	cmd.Flags().BoolVar(&searchMode, "search", false, "open Slack docs search page or search with query")


Suggested change

cmd.Flags().BoolVar(&searchMode, "search", false, "open Slack docs search page or search with query")

cmd.Flags().Bool("search", false, "open Slack docs search page or search with query")

🪓 suggestion(non-blocking): We can perhaps remove searchMode as a variable with the lookup patterns that follow. IMHO it's a nice change that we could bring to other commands...

zimeg · 2026-02-27T01:49:33Z

cmd/docs/docs.go

+var searchMode bool
+


Suggested change

var searchMode bool

🪓 suggesetion(non-blocking): Related to the earlier comment!

srtaalej

lgtm!! we can follow up on edengod's suggestions - it'd be great to land this command in the next release! 🚀

lukegalbraithrussell and others added 5 commits February 24, 2026 13:54

adds command

90dff7c

Merge branch 'main' into docs-command

c252cd7

docs not documentation

5fd56a2

go

45396a6

cleaning up tests

2c2c5e8

lukegalbraithrussell and others added 2 commits February 25, 2026 08:59

better test value

6af0af7

Merge branch 'main' into docs-command

04854d0

lukegalbraithrussell changed the title ~~Feat: adds docs command with optional search param~~ Feat: adds docs command with optional search flag Feb 25, 2026

lukegalbraithrussell commented Feb 25, 2026

View reviewed changes

cmd/docs/docs_test.go Show resolved Hide resolved

lukegalbraithrussell marked this pull request as ready for review February 25, 2026 17:27

lukegalbraithrussell requested a review from a team as a code owner February 25, 2026 17:27

zimeg reviewed Feb 26, 2026

View reviewed changes

zimeg changed the title ~~Feat: adds docs command with optional search flag~~ feat: adds docs command with optional search flag Feb 26, 2026

zimeg added enhancement M-T: A feature request for new functionality changelog Use on updates to be included in the release notes semver:minor Use on pull requests to describe the release version increment labels Feb 26, 2026

zimeg added this to the Next Release milestone Feb 26, 2026

lukegalbraithrussell added 2 commits February 26, 2026 08:50

feedback from edengod

aad04d0

Merge branch 'docs-command' of https://github.com/slackapi/slack-cli …

9c8bb4c

…into docs-command

zimeg reviewed Feb 26, 2026

View reviewed changes

lukegalbraithrussell added 3 commits February 26, 2026 10:25

go

1d12927

updates to be better

29ee8ee

lint

35153a9

lukegalbraithrussell requested a review from zimeg February 26, 2026 22:05

zimeg reviewed Feb 26, 2026

View reviewed changes

takes all inputs

7a2b2b9

lukegalbraithrussell requested a review from zimeg February 27, 2026 01:34

zimeg approved these changes Feb 27, 2026

View reviewed changes

srtaalej assigned lukegalbraithrussell Feb 27, 2026

srtaalej self-requested a review February 27, 2026 20:21

srtaalej approved these changes Feb 27, 2026

View reviewed changes

srtaalej and others added 2 commits February 27, 2026 15:29

Merge branch 'main' into docs-command

2634721

Merge branch 'main' into docs-command

030644f

zimeg merged commit 36b3af3 into main Feb 27, 2026
8 checks passed

zimeg deleted the docs-command branch February 27, 2026 20:53


		clients.Browser().OpenURL(docsURL)

		// Add trace for analytics

	cmd.Flags().BoolVar(&searchMode, "search", false, "open Slack docs search page or search with query")
	cmd.Flags().Bool("search", false, "open Slack docs search page or search with query")

Conversation

lukegalbraithrussell commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Summary

Requirements

Uh oh!

codecov bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lukegalbraithrussell commented Feb 26, 2026

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zimeg Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

lukegalbraithrussell Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg left a comment

Choose a reason for hiding this comment

Uh oh!

zimeg Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

zimeg Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

srtaalej left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lukegalbraithrussell commented Feb 24, 2026 •

edited

Loading

codecov bot commented Feb 24, 2026 •

edited

Loading